Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Conversation

@ikyatov
Copy link

@ikyatov ikyatov commented Mar 9, 2018

…stem:coredns' is forbidden and fix empty temp/coredns-deployment.yaml

Windows 10 Home,
VirtualBox 5.2.8,
Vagrant 2.0.2.

…stem:coredns' is forbidden and fix empty temp/coredns-deployment.yaml

    WIndows 10 Home,
    VirtualBox 5.2.8,
    Vagrant 2.0.2.
Copy link
Collaborator

@bmcustodio bmcustodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abyss89 thank you for this PR. If it is still relevant, could you please rebase onto master and fix the conflicts?

# in CoreOS, so tell Vagrant that so it can be smarter.
v.check_guest_additions = false
v.functional_vboxsf = false
v.customize ["modifyvm", :id, "--paravirtprovider", "minimal"] # fix freeze "vagrant up" on master: SSH auth method: private key
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now in master, so please remove it.

# - kind: ServiceAccount
# name: coredns
# namespace: kube-system
---
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling RBAC objects doesn't seem right. Why did you do this?

system "#{__dir__}/plugins/dns/coredns/deploy.sh 10.100.0.10/24 #{DNS_DOMAIN} #{__dir__}/plugins/dns/coredns/coredns.yaml.sed > #{__dir__}/temp/coredns-deployment.yaml"
system "cp #{__dir__}/plugins/dns/coredns/coredns-deployment.yaml #{__dir__}/temp/coredns-deployment.yaml" # copying a manually compiled file
# don't work, why??
#system "#{__dir__}/plugins/dns/coredns/deploy.sh 10.100.0.10/24 #{DNS_DOMAIN} #{__dir__}/plugins/dns/coredns/coredns.yaml.sed > #{__dir__}/temp/coredns-deployment.yaml"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, explain this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants