Skip to content

Brand new PR#51

Open
pkaminski wants to merge 3 commits intoworkfrom
pkaminski-patch-2
Open

Brand new PR#51
pkaminski wants to merge 3 commits intoworkfrom
pkaminski-patch-2

Conversation

@pkaminski
Copy link
Owner

Review on Reviewable

@pkaminski
Copy link
Owner Author

pkaminski commented Jan 23, 2016

Top-level comment from GitHub. :lgtm:

@pkaminski
Copy link
Owner Author

Top-level comment from Reviewable.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

And another one.


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.


bar.txt, line 1 [r1] (raw file):
Foo me.


bar.txt, line 4 [r1] (raw file):
I like fun.


bar.txt, line 5 [r1] (raw file):
Too much wheeing! Stop it!


Comments from the review on Reviewable.io

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


bar.txt, line 3 [r1] (raw file):
Another one.


Comments from the review on Reviewable.io

@pkaminski-test
Copy link
Collaborator

bar.txt, line 3 [r1] (raw file):
And another.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

bar.txt, line 5 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.


bar.txt, line 8 [r1] (raw file):
New comment from PR author.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

bar.txt, line 8 [r1] (raw file):
Invoke @author


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.


bar.txt, line 5 [r1] (raw file):
BunnyEchoSmall.png
✂-1
CodeLogo.png


bar.txt, line 8 [r1] (raw file):
Invoke @pkaminski-test


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.


bar.txt, line 8 [r1] (raw file):
A fresh comment.


Comments from the review on Reviewable.io

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.


bar.txt, line 7 [r3] (raw file):
Do you hear me, @pkaminski?


Comments from the review on Reviewable.io

@pkaminski-test
Copy link
Collaborator

bar.txt, line 8 [r1] (raw file):
Noreally @pkaminski


Comments from the review on Reviewable.io

@pkaminski pkaminski modified the milestone: v1.0 Feb 3, 2016
@pkaminski pkaminski removed this from the v1.0 milestone Feb 4, 2016
@pkaminski
Copy link
Owner Author

SADSAadsfsasdfasdfas -v1.0


Comments from the review on Reviewable.io

@pkaminski pkaminski added this to the v2.0 milestone Feb 4, 2016
@pkaminski
Copy link
Owner Author

+(version 3) +v2.0


Comments from the review on Reviewable.io

@pkaminski pkaminski modified the milestones: v2.0, version 3 Feb 4, 2016
@pkaminski pkaminski added the bug Something went wrong label Feb 4, 2016
@pkaminski pkaminski removed this from the version 3 milestone Feb 4, 2016
@pkaminski
Copy link
Owner Author

-(version 3)


Comments from the review on Reviewable.io

@pkaminski pkaminski added this to the v2.0 milestone Feb 4, 2016
@pkaminski
Copy link
Owner Author

+v2.0


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Reviewed 1 of 1 files at r1.
Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.


Comments from the review on Reviewable.io

3 similar comments
@pkaminski
Copy link
Owner Author

Reviewed 1 of 1 files at r1.
Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Reviewed 1 of 1 files at r1.
Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Reviewed 1 of 1 files at r1.
Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

a discussion (no related file):
A top-level discussion.


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 6 unresolved discussions.


bar.txt, line 3 [r1] (raw file):
A message


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

bar.txt, line 3 [r1] (raw file):
Something
@api_endpoint


Comments from the review on Reviewable.io

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.


bar.txt, line 1 [r3] (raw file):

foo foo foo

A satisfied message.


bar.txt, line 2 [r3] (raw file):

foo foo foo

A normal message.


Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

bar.txt, line 9 [r3] (raw file):

Bogus edit.
I need a new PR.  And a new commit.
Let's edit some more.

A new message from a reviewer.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

a discussion (no related file):

Previously, pkaminski (Piotr Kaminski) wrote…

A top-level discussion.

Never mind.

Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

bar.txt, line 6 at r1 (raw file):

So much fun!
Wheee!

Do something about this empty line please.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

bar.txt, line 6 at r1 (raw file):

Previously, pkaminski-test wrote…

Do something about this empty line please.

Foo foo bar

Comments from Reviewable

Copy link
Owner Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @pkaminski-test)

@pkaminski pkaminski force-pushed the work branch 2 times, most recently from f3c6179 to 7d27763 Compare January 6, 2025 23:35
Copy link
Owner Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo 🦄 💇

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @ghost and @pkaminski-test)

Copy link
Owner Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @ghost and @pkaminski-test)

@pkaminski
Copy link
Owner Author

Try a stop sign: 🛑

@pkaminski
Copy link
Owner Author

Now from GitHub: 🤞

Copy link
Owner Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo

@pkaminski made 1 comment.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on ghost and pkaminski-test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something went wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants