Stacked pull request by pkaminski · Pull Request #59 · pkaminski/sample

pkaminski · 2016-08-15T21:20:40Z

This change is

pkaminski · 2016-08-15T21:22:08Z

This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  

Let's add a new line on top of another PR.

A comment on the added line.

Comments from Reviewable

pkaminski-test · 2016-08-26T20:00:05Z

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

a discussion (no related file):
Normal request.

a discussion (no related file):
FYI request.

Comments from Reviewable

pkaminski-test · 2016-08-26T20:00:46Z

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.

a discussion (no related file):
FYI again.

a discussion (no related file):
Normal again.

Comments from Reviewable

pkaminski-test · 2016-08-26T20:00:59Z

Review status: 0 of 1 files reviewed at latest revision, 6 unresolved discussions.

bar.txt, line 11 [r1] (raw file):


  /// Evaluates to `true` if system is direct feedthrough and `false` otherwise.
  // auto& input_vector = input_port.get_vector(context); // where the return is

FYI line.

Comments from Reviewable

pkaminski-test · 2016-08-26T20:01:17Z

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.

bar.txt, line 13 [r1] (raw file):

  // auto& input_vector = input_port.get_vector(context); // where the return is

This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.

Normal line.

Comments from Reviewable

pkaminski · 2016-08-26T20:02:51Z

a discussion (no related file):

Previously, pkaminski-test wrote…

Normal request.

Normal reply.

Comments from Reviewable

pkaminski-test · 2016-08-26T20:03:03Z

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.

a discussion (no related file):

Previously, pkaminski (Piotr Kaminski) wrote…

Normal reply.

Another normal reply.

Comments from Reviewable

pkaminski-test · 2016-08-31T00:08:05Z

a discussion (no related file):

Previously, pkaminski-test wrote…

FYI again.

follow up

Comments from Reviewable

pkaminski · 2018-05-02T02:07:49Z

ads +invalid

Comments from Reviewable

pkaminski · 2018-05-02T02:11:52Z

+invalid

Comments from Reviewable

pkaminski · 2018-05-02T02:12:21Z

+invalid

Comments from Reviewable

pkaminski · 2018-05-15T23:15:06Z

bar.txt, line 11 at r1 (raw file):


  /// Evaluates to `true` if system is direct feedthrough and `false` otherwise.
  // auto& input_vector = input_port.get_vector(context); // where the return is

A blocking comment from the author.

Comments from Reviewable

pkaminski · 2018-05-17T06:49:13Z

Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.

a discussion (no related file):
fyi this is an informing comment

Comments from Reviewable

pkaminski · 2018-05-26T05:09:27Z

Dismissed @pkaminski-test from a discussion.
Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.

a discussion (no related file):
Discussing initial comment from author.

a discussion (no related file):
Blocking initial comment from author.

Comments from Reviewable

pkaminski-test · 2018-05-26T18:40:39Z

Review status: 0 of 1 files reviewed at latest revision, 10 unresolved discussions.

a discussion (no related file):
FYI informing comment from reviewer.

a discussion (no related file):
Minor: discussing comment from reviewer.

a discussion (no related file):
A blocking comment from reviewer.

Comments from Reviewable

pkaminski · 2018-05-26T22:45:11Z

Review status: 0 of 1 files reviewed at latest revision, 12 unresolved discussions.

a discussion (no related file):

Previously, pkaminski-test wrote…

A blocking comment from reviewer.

Done.

a discussion (no related file):

Previously, pkaminski-test wrote…

Minor: discussing comment from reviewer.

Are you sure?

Comments from Reviewable

pkaminski · 2018-05-27T02:58:30Z

Review status: 0 of 1 files reviewed at latest revision, 12 unresolved discussions.

a discussion (no related file):
Old informational discussion.

Comments from Reviewable

pkaminski · 2018-05-27T02:59:05Z

Review status: 0 of 1 files reviewed at latest revision, 12 unresolved discussions.

a discussion (no related file):
Actual old informational discussion.

Comments from Reviewable

pkaminski · 2018-05-27T04:10:46Z

a discussion (no related file):

Previously, pkaminski-test wrote…

follow up

I meant to follow up.

Comments from Reviewable

pkaminski · 2018-05-27T04:38:35Z

Review status: 0 of 1 files reviewed at latest revision, 9 unresolved discussions.

a discussion (no related file):

Previously, pkaminski (Piotr Kaminski) wrote…

I meant to follow up.

Another followup.

Comments from Reviewable

pkaminski · 2018-05-27T07:48:43Z

bar.txt

@@ -11,3 +11,5 @@ Another bogus edit.
  // auto& input_vector = input_port.get_vector(context); // where the return is


Here's a random comment coming from GitHub.

pkaminski · 2018-05-27T18:11:36Z

Top level follow up.

Comments from Reviewable

pkaminski · 2018-05-27T18:17:17Z

test ets

Comments from Reviewable

pkaminski · 2025-03-27T22:24:43Z

-invalid

pkaminski

-(:cake: Cake)

adsf

Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @pkaminski-test)

pkaminski

+(:cake: Cake)

Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @pkaminski-test)

pkaminski

+(Review each commit)

Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @pkaminski-test)

pkaminski

-(Review each commit)

Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @pkaminski-test)

pkaminski

foo

Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @pkaminski-test)

pkaminski

bar

Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @pkaminski-test)

pkaminski

asd

Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @pkaminski-test)

Stacked pull request

bdc9b3d

pkaminski changed the base branch from pkaminski-patch-3 to work August 15, 2016 21:22

pkaminski changed the base branch from work to pkaminski-patch-3 August 15, 2016 21:25

pkaminski added the invalid Issue doesn't make sense label May 2, 2018

pkaminski commented May 27, 2018

View reviewed changes

pkaminski requested a review from pkaminski-test September 16, 2020 05:57

pkaminski added the 🍰 Cake label Mar 27, 2025

pkaminski removed invalid Issue doesn't make sense 🍰 Cake labels Mar 27, 2025

pkaminski commented Mar 28, 2025

View reviewed changes

pkaminski added the 🍰 Cake label Mar 28, 2025

pkaminski commented Mar 28, 2025

View reviewed changes

pkaminski added the Review each commit label Mar 28, 2025

pkaminski commented Mar 28, 2025

View reviewed changes

pkaminski removed the Review each commit label Mar 28, 2025

pkaminski commented Mar 28, 2025

View reviewed changes

		@@ -11,3 +11,5 @@ Another bogus edit.
		// auto& input_vector = input_port.get_vector(context); // where the return is

Conversation

pkaminski commented Aug 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkaminski commented Aug 15, 2016

Uh oh!

pkaminski-test commented Aug 26, 2016

Uh oh!

pkaminski-test commented Aug 26, 2016

Uh oh!

pkaminski-test commented Aug 26, 2016

Uh oh!

pkaminski-test commented Aug 26, 2016

Uh oh!

pkaminski commented Aug 26, 2016

Uh oh!

pkaminski-test commented Aug 26, 2016

Uh oh!

pkaminski-test commented Aug 31, 2016

Uh oh!

pkaminski commented May 2, 2018

Uh oh!

pkaminski commented May 2, 2018

Uh oh!

pkaminski commented May 2, 2018

Uh oh!

pkaminski commented May 15, 2018

Uh oh!

pkaminski commented May 17, 2018

Uh oh!

pkaminski commented May 26, 2018

Uh oh!

pkaminski-test commented May 26, 2018

Uh oh!

pkaminski commented May 26, 2018

Uh oh!

pkaminski commented May 27, 2018

Uh oh!

pkaminski commented May 27, 2018

Uh oh!

pkaminski commented May 27, 2018

Uh oh!

pkaminski commented May 27, 2018

Uh oh!

pkaminski May 27, 2018

Choose a reason for hiding this comment

Uh oh!

pkaminski commented May 27, 2018

Uh oh!

pkaminski commented May 27, 2018

Uh oh!

pkaminski commented Mar 27, 2025

Uh oh!

pkaminski left a comment

Choose a reason for hiding this comment

Uh oh!

pkaminski left a comment

Choose a reason for hiding this comment

Uh oh!

pkaminski left a comment

Choose a reason for hiding this comment

Uh oh!

pkaminski left a comment

Choose a reason for hiding this comment

Uh oh!

pkaminski left a comment

Choose a reason for hiding this comment

Uh oh!

pkaminski left a comment

Choose a reason for hiding this comment

Uh oh!

pkaminski left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

pkaminski commented Aug 15, 2016 •

edited

Loading