Skip to content

Clean change#69

Open
pkaminski wants to merge 2 commits intoworkfrom
pkaminski-patch-12
Open

Clean change#69
pkaminski wants to merge 2 commits intoworkfrom
pkaminski-patch-12

Conversation

@pkaminski
Copy link
Owner

@pkaminski pkaminski commented Jun 24, 2019

This change is Reviewable

Copy link
Owner Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@pkaminski pkaminski closed this Jun 24, 2019
@pkaminski pkaminski deleted the pkaminski-patch-12 branch June 24, 2019 05:48
@pkaminski pkaminski restored the pkaminski-patch-12 branch June 24, 2019 05:49
@pkaminski pkaminski reopened this Jun 24, 2019
@pkaminski
Copy link
Owner Author

foo.js line 3 at r1 (raw file):

function() {
	var a = 'Hello'.replace(/H/, 'X');
	// tab indent

A blocking comment.

Copy link
Owner Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions


foo.js line 4 at r1 (raw file):

	var a = 'Hello'.replace(/H/, 'X');
	// tab indent
	return 'quxxxer!';

FYI this does nothing.


foo.js line 6 at r1 (raw file):

	return 'quxxxer!';
	// trailing spaces   
}  // no newlinex

Nit just discussing.


foo.js line 6 at r2 (raw file):

	return 'quxxxer!';
	// trailing spaces   
	"further changes"

A new blocking comment.

@pkaminski
Copy link
Owner Author

foo.js line 7 at r2 (raw file):

	// trailing spaces   
	"further changes"
}  // no newlinex

Another new blocking comment.

@pkaminski pkaminski force-pushed the work branch 2 times, most recently from f3c6179 to 7d27763 Compare January 6, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant