Export generic load() function, and generate type-only .d.ts files#51
Open
jasongwartz wants to merge 4 commits intomainfrom
Open
Export generic load() function, and generate type-only .d.ts files#51jasongwartz wants to merge 4 commits intomainfrom
jasongwartz wants to merge 4 commits intomainfrom
Conversation
jackkleeman
reviewed
Aug 6, 2024
| /* DO NOT EDIT! */ | ||
| /* istanbul ignore file */ | ||
| /* eslint-disable */ | ||
| import * as pklTypescript from "@pkl-community/pkl-typescript" |
Contributor
There was a problem hiding this comment.
these imports arent needed now right?
Contributor
Author
There was a problem hiding this comment.
They are if we use custom types like pklTypescript.Any
jasongwartz
commented
Aug 6, 2024
Comment on lines
-14
to
+18
| loadFromPath(configFile).then((config) => { | ||
| console.log("Loaded config values from Pkl:", JSON.stringify(config)); | ||
| loadFromPath<ConfigSchema>(configFile) | ||
| .then((config) => { | ||
| console.log("Loaded config values from Pkl:", JSON.stringify(config)); |
Contributor
Author
There was a problem hiding this comment.
These lines best illustrate what the expected change in usage would be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.