pkp/pkp-lib#5199 Set the current page on the top menu - OMP 3.4 #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israelcefrin
force-pushed
the
i5199_set_the_current_page_on_the_top_menu
branch
from
d2738ce
to
0488910
Compare
jonasraoni
force-pushed
the
i5199_set_the_current_page_on_the_top_menu
branch
from
3c50efe
to
8bffcd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue pkp/pkp-lib#5199:
I've ported the check page function from Pragma(OJS) theme adjusting the function to add the class and the aria attribute while checking for submenus.