Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PdfJsViewerPlugin.php #1653

Open
wants to merge 1 commit into
base: stable-3_4_0
Choose a base branch
from
Open

Update PdfJsViewerPlugin.php #1653

wants to merge 1 commit into from

Conversation

adbo74
Copy link

@adbo74 adbo74 commented Jul 22, 2024

Generates the URL for the file download

@adbo74
Update PdfJsViewerPlugin.php
a9c7228 
Generates the URL for the file download
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@asmecher
Copy link
Member

Thanks, @adbo74! @kaitlinnewson, can you please review this one?

@kaitlinnewson kaitlinnewson self-assigned this Jul 23, 2024
@kaitlinnewson
Copy link
Member

kaitlinnewson commented Jul 24, 2024 •
edited
Loading

Hi @adbo74, thanks for your pull request. The downloadUrl should already be set in CatalogBookHandler - is there a bug you're encountering that prompted this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kaitlinnewson kaitlinnewson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adbo74 @CLAassistant @asmecher @kaitlinnewson