Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ror registry data set cache; update bi-weekly; api lookup feature; mi… #10426

Closed
wants to merge 17 commits into from

Conversation

GaziYucel
Copy link
Contributor

@GaziYucel GaziYucel commented Sep 17, 2024

  • Ror registry data set cache
  • update bi-weekly
  • api lookup feature
  • migration / install
  • translations
    • english is ready
    • other languages have the keys with empty message

This will be used for multiple affiliations for authors described in the issue below.

@GaziYucel
Copy link
Contributor Author

Hi @bozana
Is it necessary to add (unit) tests for this feature?

@bozana
Copy link
Collaborator

bozana commented Sep 25, 2024

Hi @GaziYucel, hmmm... I am not sure... I think the tests are always welcomed, but lets see what @asmecher says :-)

@asmecher
Copy link
Member

@GaziYucel, unit tests (and/or integration tests) are always welcome, but we are not especially strict about requiring them.

@GaziYucel GaziYucel marked this pull request as draft October 10, 2024 14:56
@GaziYucel
Copy link
Contributor Author

This is merged in #10460

@GaziYucel GaziYucel closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants