Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
moreal
left a comment
There was a problem hiding this comment.
If it can be run in nodejs 16 environment, it is not critical but it will be better to upgrade nodejs version when building bridge-www.
NineChronicles.EthBridge/.github/workflows/build-bridge-www.yaml
Lines 22 to 26 in e5eac5d
It occurred errors If node version is not v16, when starting bridge-www.
It was quite inconvenient since bridge require node v19, and we should change local node version for every single test.
Updated Module version, and Fixed duplicated execution when onClick Event.