Conversation
21c975e to
6b31bcd
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
| Field<ListGraphType<FungibleAssetValueType>>( | ||
| "favs", | ||
| resolve: context => context.Source.favs); | ||
| Field<ListGraphType<InventoryItemType>>( |
There was a problem hiding this comment.
These type should be non-nullable.
| stakedNcg), | ||
| stakeRegularRewardSheet.Keys.Max()); | ||
| var itemSheet = accountState.GetItemSheet(); | ||
| accountState.TryGetStakeStateV2(context.Source.AgentAddress, out var stakeStateV2); |
There was a problem hiding this comment.
You may be able to use context.Source.StakeState instead.
| : 1 + (int)Math.DivRem( | ||
| context.Source.BlockIndex - stakeStateV2.ClaimableBlockIndex, | ||
| stakeStateV2.Contract.RewardInterval, | ||
| out _); |
There was a problem hiding this comment.
Is this field showing the rewards you're currently eligible for?
Introduce pre-calculated stake rewards query for prepare LoadIntoMyGarages plainValue. tested from https://github.com/planetarium/NineChronicles.Headless/tree/rc-calc-stake-rewards branch