Introduce filtered argument at .nodeStatus.stagedTxIds[Count]#2563
Open
moreal wants to merge 2 commits intoplanetarium:developmentfrom
Open
Introduce filtered argument at .nodeStatus.stagedTxIds[Count]#2563moreal wants to merge 2 commits intoplanetarium:developmentfrom
filtered argument at .nodeStatus.stagedTxIds[Count]#2563moreal wants to merge 2 commits intoplanetarium:developmentfrom
Conversation
moreal
force-pushed
the
bugfix/stagedTxIdsCount
branch
3 times, most recently
from
88ce23b to
9fbdec4
Compare
moreal
force-pushed
the
bugfix/stagedTxIdsCount
branch
3 times, most recently
from
fc81cba to
7bc6405
Compare
Contributor
|
이건 @planetarium/libplanet 팀에서 봐주시는게 좋을것같습니다. |
moreal
force-pushed
the
bugfix/stagedTxIdsCount
branch
from
7bc6405 to
7dba510
Compare
moreal
force-pushed
the
bugfix/stagedTxIdsCount
branch
from
7dba510 to
9f122bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
stagedTxIdsandstagedTxIdsCountfield usesBlockChain.GetStagedTransactionIdsmethod, it usesIStagePolicy.Iterate(BlockChain chain, bool filtered)withfiltered=true. But we cannot know how many real transactions are staged now because it must not filter transactions to know that.This pull request replaces
BlockChain.GetStagedTransactionIds()call withIStagePolicy.Iterate(...)and introducesfilteredquery argument for.nodeStatus.stagedTxIdsand.nodeStatus.stagedTxIdsCountfields.