Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleGeocoderComboBox should inherit from GeoExt.form.GeocoderComboBox #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bartvde
Copy link
Contributor

@bartvde bartvde commented Sep 18, 2012

No description provided.

* names described for the :class:`gxp.form.GoogleGeocoderComboBox`.
* Default is "viewport".
*/
updateField: "viewport",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep updateField as alias for valueField (and mark updateField deprecated), to ensure backwards compatibility?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did cross my mind at one point in time. We would need to provide a mapping as well, and the values of the two don't really map well. (Also I don't recall any of our applications making use of it).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I also don't see an application use it. So maybe instead of a mapping, just something like

if ('updateField' in this.initialConfig) {
    window.setTimeout(function() {
        throw("The updateField option is no longer available.");
    }, 0);
} 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants