Skip to content

fix: skip reasoning for non-meaningful session-end uploads - #71

Closed
symphonia-ai wants to merge 1 commit into
plastic-labs:mainfrom
symphonia-ai:fix/skip-reasoning-nonmeaningful-msgs
Closed

fix: skip reasoning for non-meaningful session-end uploads#71
symphonia-ai wants to merge 1 commit into
plastic-labs:mainfrom
symphonia-ai:fix/skip-reasoning-nonmeaningful-msgs

Conversation

@symphonia-ai

@symphonia-ai symphonia-ai commented Jul 15, 2026

Copy link
Copy Markdown

Summary

  • Disable per-message reasoning for assistant uploads tagged meaningful: false (tool stubs / brief acknowledgments).
  • Same for the [Session ended] marker, which was producing junk conclusions (e.g. "session contained N messages").
  • Messages are still stored for history/summaries; only representation enqueue is skipped.

Test plan

  • End a Claude Code session that used tools; confirm brief [Used tools: …] messages still appear in Honcho, but no new representation queue items / conclusions from them.
  • End a session with real prose; confirm meaningful assistant messages still derive normally.
  • Confirm session-end marker is stored without deriving conclusions about message count.

Summary by CodeRabbit

  • Bug Fixes
    • Improved session-end messages by disabling reasoning for non-meaningful assistant responses and the final session-ended marker.

Plugin already classifies tool stubs and brief acknowledgments via
isMeaningful, but still enqueues them for representation. Set
reasoning.enabled=false on those uploads and the session-end marker so
messages stay in history without polluting peer memory.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca76632f-b2ca-45da-803d-4d96d3048dca

📥 Commits

Reviewing files that changed from the base of the PR and between 15d07cd and b4cd62b.

📒 Files selected for processing (1)
  • plugins/honcho/src/hooks/session-end.ts

Walkthrough

Session-end handling now disables reasoning for non-meaningful assistant messages and for the final [Session ended] marker through message configuration metadata.

Changes

Session-end message configuration

Layer / File(s) Summary
Configure session-end message reasoning
plugins/honcho/src/hooks/session-end.ts
Non-meaningful assistant messages and the final session-end marker now include configuration.reasoning.enabled = false.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: ajspig

Poem

I’m a rabbit with reasoning tucked away,
Marking the session’s gentle close of day.
Quiet messages hop into line,
The ending marker reads just fine.
No more thoughts for now—goodnight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to skip reasoning for non-meaningful session-end uploads.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ajspig

ajspig commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Thanks for this! Closing as superseded: the code path this PR filters no longer exists. #73 moved all message uploads to happen live, and #88 reduced SessionEnd to pure logging and state cleanup (session-end no longer uploads anything) so there's nothing left to skip reasoning for. The underlying concern (non-meaningful content burning deriver cycles) is also addressed in #77, which disables reasoning on terse acknowledgements at upload time.

@ajspig ajspig closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants