fix: skip reasoning for non-meaningful session-end uploads - #71
fix: skip reasoning for non-meaningful session-end uploads#71symphonia-ai wants to merge 1 commit into
Conversation
Plugin already classifies tool stubs and brief acknowledgments via isMeaningful, but still enqueues them for representation. Set reasoning.enabled=false on those uploads and the session-end marker so messages stay in history without polluting peer memory.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughSession-end handling now disables reasoning for non-meaningful assistant messages and for the final ChangesSession-end message configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for this! Closing as superseded: the code path this PR filters no longer exists. #73 moved all message uploads to happen live, and #88 reduced SessionEnd to pure logging and state cleanup (session-end no longer uploads anything) so there's nothing left to skip reasoning for. The underlying concern (non-meaningful content burning deriver cycles) is also addressed in #77, which disables reasoning on terse acknowledgements at upload time. |
Summary
reasoningfor assistant uploads taggedmeaningful: false(tool stubs / brief acknowledgments).[Session ended]marker, which was producing junk conclusions (e.g. "session contained N messages").Test plan
[Used tools: …]messages still appear in Honcho, but no new representation queue items / conclusions from them.Summary by CodeRabbit