Skip to content

Made sure deserialize throws a better exception when one of the membe… #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made sure deserialize throws a better exception when one of the membe… #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/Platform.Xml.Serialization/StringableTypeSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,25 @@ public override string Serialize(object obj, SerializationContext state)
/// </summary>
public override object Deserialize(string value, SerializationContext state)
{
if (formatSpecified)
{
return Convert.ChangeType(value, supportedType, formatAttribute.CultureInfo);
}

try
{
if (formatSpecified)
{
return Convert.ChangeType(value, supportedType, formatAttribute.CultureInfo);
}

return Convert.ChangeType(value, supportedType);
return Convert.ChangeType(value, supportedType);
}
catch(Exception ex)
{
var memberInfo = state.GetCurrentMemberInfo().MemberInfo;
throw new Exception(string.Format("Can't deserialize property {0} of class {1}. Could not convert value '{2}' to type {3}",
memberInfo.Name,
memberInfo.DeclaringType.FullName,
value,
supportedType), ex);
}
}
}
}