Added attiny84_cw_pinmap board option#336
Open
nickyonge wants to merge 1 commit intoplatformio:masterfrom
Open
Added attiny84_cw_pinmap board option#336nickyonge wants to merge 1 commit intoplatformio:masterfrom
nickyonge wants to merge 1 commit intoplatformio:masterfrom
Conversation
Created a board for ATtiny84 using the reverse (clockwise) pin mappinig, as opposed to the default CCW pinmapping. Reads from the "tinyX4_reverse" board variant. Why? Tldr: the mapping has changed over time, and newer projects generally use CW mapping. It's odd that pio defaults to CCW. Adding this to the list would at least make it easily (and EXPLICITLY, no ambiguity) selectable, without breaking pre-existing projects by modifying the original "attiny84" board. See https://github.com/SpenceKonde/ATTinyCore/blob/v2.0.0-devThis-is-the-head-submit-PRs-against-this/avr/extras/ATtiny_x4.md for details on why this pinmapping exists. Found it exhausting to manually add the variant every time despite it pre-existing in the boards list.
Member
|
Hi @nickyonge, thanks for the PR. I'd recommend renaming the board manifest to a more concise variant (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a board for ATtiny84 using the reverse (clockwise) pin mappinig, as opposed to the default CCW pinmapping. Reads from the "tinyX4_reverse" board variant.
Why? Tldr: the mapping has changed over time, and newer projects generally use CW mapping. It's odd that pio defaults to CCW. Adding this to the list would at least make it easily (and EXPLICITLY, no ambiguity) selectable, without breaking pre-existing projects by modifying the original "attiny84" board.
See https://github.com/SpenceKonde/ATTinyCore/blob/v2.0.0-devThis-is-the-head-submit-PRs-against-this/avr/extras/ATtiny_x4.md for details on why this pinmapping exists.
Found it exhausting to manually add the variant every time despite it pre-existing in the boards list.