-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pushing template changes #4348
base: main
Are you sure you want to change the base?
feat: pushing template changes #4348
Conversation
realised too late that templates are fixed so only django is hard coded at the moment
…-drupal-django-gatsby-strapi-micronaut-quarkus-and-spring-with-hardcoded-examples
…-drupal-django-gatsby-strapi-micronaut-quarkus-and-spring-with-hardcoded-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last thing is, in the name of the services, the version is set... but is hardcoded
I think we should use the "generic" name (ex: redis
) instead of the "versioned" name (ex: redis6
), or use the shortcode {{% latest "redis" %}}
to dynamically display it in the name.
@gilzow what do you think ?
"hostname": "jmgjydr275pkj5v7prdj2asgxm.elasticsearch77.service._.eu-3.platformsh.site", | ||
"epoch": 0, | ||
"instance_ips": [ | ||
"247.229.144.158" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.elasticsearch77.service._.eu-1.platformsh.site",
"host": "headlesschrome.internal", | ||
"cluster": "rjify4yjcwxaa-master-7rqtwti", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.headlesschrome.service._.eu-1.platformsh.site",
"host": "influxdb.internal", | ||
"cluster": "rjify4yjcwxaa-master-7rqtwti", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.influxdb18.service._.eu-1.platformsh.site",
"host": "kafka.internal", | ||
"cluster": "rjify4yjcwxaa-master-7rqtwti", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.kafka25.service._.eu-1.platformsh.site",
"host": "memcached.internal", | ||
"cluster": "rjify4yjcwxaa-master-7rqtwti", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.memcached16.service._.eu-1.platformsh.site",
"port": 5432, | ||
"host_mapped": false, | ||
"service": "postgresql12", | ||
"hostname": "zydalrxgkhif2czr3xqth3qkue.postgresql12.service._.eu-3.platformsh.site", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.postgresql12.service._.eu-1.platformsh.site",
"port": 5672, | ||
"host_mapped": false, | ||
"service": "rabbitmq39", | ||
"hostname": "453lqa3dz2ekflsrm7whfdhbiq.rabbitmq39.service._.eu-3.platformsh.site", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.rabbitmq39.service._.eu-1.platformsh.site",
"port": 6379, | ||
"host_mapped": false, | ||
"service": "redis6", | ||
"hostname": "7mnenhdiz7ecraovljrba6pmiy.redis6.service._.eu-3.platformsh.site", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.redis6.service._.eu-1.platformsh.site",
"port": 8080, | ||
"host_mapped": false, | ||
"service": "solr86", | ||
"hostname": "csjsvtdhmjrdre2uaoeim22xjy.solr86.service._.eu-3.platformsh.site", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.solr86.service._.eu-1.platformsh.site",
"port": 8200, | ||
"host_mapped": false, | ||
"service": "vault-kms", | ||
"hostname": "ckmpv2fz7jtdmpkmrun7yfgut4.vault-kms.service._.eu-3.platformsh.site", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not expose potential IPs ;)
for such config, please use:
- IP: 123.456.78.90
- "hostname": "azertyuiopqsdfghjklm.vault-kms.service._.eu-1.platformsh.site",
…-drupal-django-gatsby-strapi-micronaut-quarkus-and-spring-with-hardcoded-examples
Your Platform.sh environment has successfully deployed. 🚀 See the changed pages: Platform.sh docsUpsun docs |
Templates.yaml for all frameworks have been fixed (not by me!) so routes yaml snippets should be working now. I didn't realise that the templates.yaml had been fixed already so I went in and hard coded the Django routes.yaml section. I only realised that the others were working when I ran it all locally.
So right now, just Django is hard coded. I thought it'd be better to leave it hard coded so we can go ahead and hard code the rest in future if we need to.
Why
Closes #4342
What's changed
All framework templates and the define routes section (bottom of page) on the Django page.
Where are changes
Updates are for:
sites/platform
templates)sites/upsun
templates)