Add workaround for Clickhouse query condition cache bug - #6562
Open
apata wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
There's a Clickhouse bug (fixed upstream in ClickHouse/ClickHouse#108488) that causes queries to return invalid values when run after a sampled query. This workaround disables
use_query_condition_cachefor all sampled queries and almost all queries in general (just not on the server/cluster as a whole). Can be removed when CH is updated.I tried targeting just sampled queries (at the point where we add the log_comment setting to the query), but the sample statement can be deep in the Ecto query, so I didn't think it was durable enough.
Tests
Changelog
Documentation
Dark mode