Skip to content

Conversation

@aidinabedi
Copy link
Contributor

@aidinabedi aidinabedi commented Oct 31, 2025

Description

This PR takes the type info from the parameter definition in Shader's constructor, and makes it into its own typedef called ShaderDefinition, so that it can be used to also document the property Shader.definition

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'm not sure about exposing definition as the public API. Two concerns:

  1. It seems the user can modify it's content, but in reality it cannot.
  2. The content of it is not the same as what the user passed in. As an example we process shaders and replace the originally supplied shaders. And so we cannot provide guarantees as of what it contains.

What's the reason you need definition exposed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants