-
Notifications
You must be signed in to change notification settings - Fork 57
feat: add solution for day 30 #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new utility function Changes
Sequence DiagramsequenceDiagram
participant Input as Date Strings
participant Func as calculateDateDiff
participant DateObj as Date Objects
participant Result as Day Difference
Input ->> Func: fromDate, toDate
Func ->> DateObj: Convert strings to Date objects
DateObj ->> Result: Calculate time difference
Result -->> Func: Return days difference
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
daily-challenges/2024-09/30/hunghoang3110.spec.ts
(1 hunks)
🔇 Additional comments (1)
daily-challenges/2024-09/30/hunghoang3110.spec.ts (1)
4-5
: Handle invalid date strings gracefully.
Splitting and directly instantiating a Date
object can lead to invalid dates if the string is incorrectly formatted. Consider adding validation or error handling logic to ensure the input strings follow the "DD/MM/YYYY" format.
Also applies to: 6-7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix my comment
Summary by CodeRabbit
New Features
Documentation