feat(reanimated): useAnimatedScrollHandler, withDelay #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created a local branch with react 18 to test the RN PR and seems to be working: react-lightning-pr.mov |
WillsonHaw
reviewed
Oct 23, 2025
| useAnimatedScrollHandler as useAnimatedScrollHandlerRN, | ||
| } from 'react-native-reanimated-original'; | ||
|
|
||
| type UseAnimatedScrollHandlerFn = ( |
There was a problem hiding this comment.
Couldn't this just be type UseAnimatedScrollHandlerFn = typeof useAnimatedScrollHandlerRN?
There was a problem hiding this comment.
I was having some typescript issues with the context type. If I spread the args everything seems more stable on the ts side.
thealmarques
force-pushed
the
am/inline-preview-fixes
branch
from
dce06e2 to
71c62b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/plexinc/react-native-client/pull/3697 I noticed that the lightning version had stopped working. After some debug I discovered that we need to have a custom implementation for:
1 -
useAnimatedScrollHandler, in the react native app we rely onscrollYto determine when we need to expand/collapse the previews when going up.2 -
withDelaywasn't working but lighting animations already supports it we just have to pass the attribute on the config.I tried to link this package but without success. After linking if I try to run
pnpm plex-lng:devI get:Another issue I had was the
pnpm check:typeson this codebase. I was having issues non related with my changes (I also had them onmain).In theory if you checkout the latest commit https://github.com/plexinc/react-native-client/pull/3697 and test these changes there it should work.