Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config with default template 2.0.1.dev0 #4121

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

gforcada
Copy link
Member

The big elephant in the room 😅

  • plone.api usage: I refactored some tests that were using plone.api they are on the last commit, so if it's fine to keep them like that, we can drop the commit and add plone.api as another dependency to ignore.
  • tests do not run locally: tox -e test fails with not being able to create a gopip index, which is something coming from plone.folder but somehow, during the test setup that code is still not there? 🤔 Might it be that it has something to do with not using buildout? (see below for the traceback)
  • all dependencies have been cleaned up
  • i18ndude has been disabled, as it reports so much stuff 😅 @erral we might want to have a look at it at some point, but as templates are going to be moved, on their destination (mostly plone.app.layout they will be cleaned up there 🤞🏾
  • I skipped reformatting templates with zpretty, in the past, massive reformatting lead to very quirky to find errors, again like with i18ndude, as templates are to be moved, they can be reformatted on their target destination? 🤔
The traceback when running tox -e test:

Could not install product Products.CMFPlone
Set up plone.app.testing.layers.PloneFixture Traceback (most recent call last):
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/zope/testrunner/runner.py", line 474, in run_layer
setup_layer(options, layer, setup_layers)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/zope/testrunner/runner.py", line 839, in setup_layer
setup_layer(options, base, setup_layers)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/zope/testrunner/runner.py", line 844, in setup_layer
layer.setUp()
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/plone/app/testing/layers.py", line 89, in setUp
self.setUpDefaultContent(app)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/plone/app/testing/layers.py", line 209, in setUpDefaultContent
addPloneSite(
File "/home/runnerProducts.CMFPlone/Products/CMFPlone/factory.py", line 205, in addPloneSite
setup_tool.runAllImportStepsFromProfile("profile-%s" % profile_id)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/tool.py", line 393, in runAllImportStepsFromProfile
result = self._runImportStepsFromContext(

  • traceback_info: profile-Products.CMFPlone:plone
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/tool.py", line 1504, in _runImportStepsFromContext
    message = self._doRunImportStep(step, context)
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/tool.py", line 1316, in _doRunImportStep
    return handler(context)
  • traceback_info: catalog
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/CMFCore/exportimport/catalog.py", line 34, in importCatalogTool
    importObjects(tool, '', context)
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/utils.py", line 949, in importObjects
    importer.body = body
  • traceback_info: portal_catalog
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/utils.py", line 553, in _importBody
    self._importNode(dom.documentElement)
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/ZCatalog/exportimport.py", line 68, in _importNode
    self._initIndexes(node)
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/ZCatalog/exportimport.py", line 115, in _initIndexes
    zcatalog.addIndex(idx_id, meta_type, extra)
    File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/ZCatalog/ZCatalog.py", line 846, in addIndex
    raise ValueError("Index of type %s not found" % type)
    ValueError: Index of type GopipIndex not found

@erral
Copy link
Member

erral commented Feb 21, 2025

don't worry about i18ndude check.

@gforcada gforcada force-pushed the config-with-default-template-2.0.1.dev0 branch from 164d99d to fc20467 Compare February 21, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants