-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config with default template 2.0.1.dev0 #4121
Open
gforcada
wants to merge
16
commits into
master
Choose a base branch
from
config-with-default-template-2.0.1.dev0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't worry about |
164d99d
to
fc20467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big elephant in the room 😅
plone.api
usage: I refactored some tests that were usingplone.api
they are on the last commit, so if it's fine to keep them like that, we can drop the commit and addplone.api
as another dependency to ignore.tox -e test
fails with not being able to create agopip index
, which is something coming fromplone.folder
but somehow, during the test setup that code is still not there? 🤔 Might it be that it has something to do with not using buildout? (see below for the traceback)i18ndude
has been disabled, as it reports so much stuff 😅 @erral we might want to have a look at it at some point, but as templates are going to be moved, on their destination (mostlyplone.app.layout
they will be cleaned up there 🤞🏾zpretty
, in the past, massive reformatting lead to very quirky to find errors, again like withi18ndude
, as templates are to be moved, they can be reformatted on their target destination? 🤔The traceback when running
tox -e test
:Could not install product Products.CMFPlone
Set up plone.app.testing.layers.PloneFixture Traceback (most recent call last):
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/zope/testrunner/runner.py", line 474, in run_layer
setup_layer(options, layer, setup_layers)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/zope/testrunner/runner.py", line 839, in setup_layer
setup_layer(options, base, setup_layers)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/zope/testrunner/runner.py", line 844, in setup_layer
layer.setUp()
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/plone/app/testing/layers.py", line 89, in setUp
self.setUpDefaultContent(app)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/plone/app/testing/layers.py", line 209, in setUpDefaultContent
addPloneSite(
File "/home/runnerProducts.CMFPlone/Products/CMFPlone/factory.py", line 205, in addPloneSite
setup_tool.runAllImportStepsFromProfile("profile-%s" % profile_id)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/tool.py", line 393, in runAllImportStepsFromProfile
result = self._runImportStepsFromContext(
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/tool.py", line 1504, in _runImportStepsFromContext
message = self._doRunImportStep(step, context)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/tool.py", line 1316, in _doRunImportStep
return handler(context)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/CMFCore/exportimport/catalog.py", line 34, in importCatalogTool
importObjects(tool, '', context)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/utils.py", line 949, in importObjects
importer.body = body
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/utils.py", line 553, in _importBody
self._importNode(dom.documentElement)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/ZCatalog/exportimport.py", line 68, in _importNode
self._initIndexes(node)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/GenericSetup/ZCatalog/exportimport.py", line 115, in _initIndexes
zcatalog.addIndex(idx_id, meta_type, extra)
File "/home/runnerProducts.CMFPlone/.tox/test/lib/python3.13/site-packages/Products/ZCatalog/ZCatalog.py", line 846, in addIndex
raise ValueError("Index of type %s not found" % type)
ValueError: Index of type GopipIndex not found