Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook demo #1425

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Storybook demo #1425

wants to merge 9 commits into from

Conversation

ninanoleto
Copy link

No description provided.

@ninanoleto ninanoleto force-pushed the storybook-demo branch 2 times, most recently from c9dc48d to 4847935 Compare February 12, 2025 08:42
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Makefile commands should be added to the README.md, which also serves as Mockup's contributing guide for developers.

@ninanoleto ninanoleto force-pushed the storybook-demo branch 2 times, most recently from 261ae2b to 450b5ea Compare February 13, 2025 12:05
],
});

// TODO: make the mock work
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was chatting with some Volto folks, and they pointed me to https://6.docs.plone.org/storybook/?path=/story/edit-widgets-object-browser--single-element. I don't know whether any of that can be reused here. Also sometimes Storybook components break, as we don't have a way to test them in CI.

For a fully working demo, visit https://volto.demo.plone.org/, login as admin/admin, edit the page, then insert an image block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants