-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added upload and download aliases in csv format. #1813
Conversation
@Faakhir30 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
Hmm... the RTD preview build is still broken. I'll fiddle with its settings. |
@jenkins-plone-org please run jobs |
RTD preview looks good. This is ready for technical review. I think the Jenkins failures are flaky tests. I started a retry for the two failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM codewise, looks like some test is failing
The test failing Also, I'm unable to understand its relation with this |
Previously two Jenkins builds failed, now it's down to one. I started one more retry. https://jenkins.plone.org/job/pull-request-6.1-3.12/639/ Those failures are totally unrelated to this PR, so I'm OK with ignoring them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Faakhir30 In general I'd like to have a chance to look at new features before they are merged, and I hadn't had a chance to look at this one yet. But it looks like good work. Thank you!
@davisagli understood, will make sure of your review on feature PRs from now on :) |
Refers #1812
Closes #1793
Using content negotiation for PUT, GET aliases service.
Tasks breakdown:
text/csv
content-type to upload aliases in bulk.text/csv
content-type to download aliases.plone.restapi
.📚 Documentation preview 📚: https://plonerestapi--1813.org.readthedocs.build/