Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle block deserializers in control panels #1875

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Jan 31, 2025

Fixes #1868

@mister-roboto
Copy link

@JeffersonBledsoe thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffersonBledsoe It looks plausible to me, but I'd really like to see a test confirming that the resolveuid transforms are applied. Also don't we probably need something similar for the serializer?

@JeffersonBledsoe JeffersonBledsoe marked this pull request as draft February 4, 2025 11:29
@JeffersonBledsoe
Copy link
Member Author

@JeffersonBledsoe It looks plausible to me, but I'd really like to see a test confirming that the resolveuid transforms are applied. Also don't we probably need something similar for the serializer?

Yep, I'll get round to those soon hopefully! The current status is what was needed for a project, I'll add the tests and the serializer part of the story soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block transforms don't run for control panels
3 participants