Skip to content

get multilingual settings and available languages from backend #6818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erral
Copy link
Member

@erral erral commented Mar 7, 2025

Caution

The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.



This supersedes #5506

@sneridagh as commented, I have created a new PR with the changes.

We have 2 things (at least), to address:

  • The @addons endpoint is for Managers only, so we would need to get the isMultilingual to the @site endpoint.
  • How do we configure Volto to get the translations expander in each content request? Right now we do this in the getContent action getting the value from settings. I don't know if querying the redux state in the action body is acceptable at all.

Anyway, this is open to discussion.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 0295909
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67d0123995f5ca000832e985

@sneridagh
Copy link
Member

@erral oh I was unaware of that. Let's put the multilingual check in the @site endpoint.
I might look into it this weekend.
Regarding the state lookup in the action, it can be done, and it's acceptable. It's the use case that an action depends on another action (a thunk), but the request would be in there already (I guess). We can try.

@pnicolli
Copy link
Contributor

@erral Do you see any issues in adding this to Volto 18? Is it breaking if sites don't have the latest restapi version? As discussed in the Volto Team Meeting today, the #6807 PR is going in 19 so maybe this one should go in Volto 19 as well?

@erral
Copy link
Member Author

erral commented Mar 11, 2025

Right now this PR requires latests plone.restapi (9.12).

But I hav no problem on waiting to 19, and we can include there these and the Pr you mentioned.

@sneridagh sneridagh added this to the 19.x.x milestone Mar 19, 2025
@pnicolli pnicolli moved this from Needs discussion to Plan approved in Volto Team Meeting Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Plan approved
Development

Successfully merging this pull request may close these issues.

3 participants