Login acceptance tests, improve login form #6944
Conversation
|
Test is simple and straightforward and I'm ok with it at this time. Looking ahead in the future, I am not a fan of having the tests in a different package from the code, but I'm not a cypress expert, I'm not sure if there's a way that is still simple and allows test code to be colocated with add-on code. |
|
@pnicolli I had exactly the same doubt yesterday. We need to talk about it. I want to add a couple of more tests, and probably implement a logout. It's what testing things has, it brings more things to do! |
* seven: Remove news items that have already been synced with main or released [Seven] Added logout route (#6972) Improve Button TW component (#6946) Added missing release-management-notes document, amend here and there (#6951) Enable pull request previews on Read the Docs (#6950) Added favicon to Storybook build (#6948) Purge non-Seven docs (#6947) Some amendments to main README (#6941)
|
@pnicolli ready now. I centralized the Cypress testing in |
| if ( | ||
| /hydrat/i.test(err.message) || | ||
| /ydrat/i.test(err.message) || |
There was a problem hiding this comment.
Is this an accidental deletion?
Also it looks like a copy-paste from a GitHub issue cypress-io/cypress#27204 (comment). I think we should have an issue in Volto's issue tracker to track it and remove it when it is fixed. That will also allow you to spread the maintenance workload and relieve your brain of being the sole source.
There was a problem hiding this comment.
Not a typo, is fine. Sometimes the error message has a Capital letter (because it's the start of a sentence) and in other occasions, it does not. The error is still present in Cypress 14 unfortunately :(
Anyways, it's a minor thing.
Co-authored-by: Steve Piercy <[email protected]>
|
@pnicolli going ahead and merging! Please tell me if there's anything that you miss/change! |
(WIP)