Skip to content

Fix CI #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
May 28, 2025
Merged

Fix CI #3305

merged 60 commits into from
May 28, 2025

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented May 26, 2025

I've identified two different issue in the recent CI failures:

  • setuptools >=80.0.0 changed something with the path resolution of local installed package, breaking the typing tests. I also migrated the tests to run on github workflow instead.
  • Migrated the background callback tests to run on github workflow instead of circleci, the tests now passes. There is a new v2 container on circleci that seems to be the culprit.

Also ignore the new html attribute from #3295

@gvwilson
Copy link
Contributor

great work @T4rk1n - thanks for figuring this out.

@gvwilson gvwilson added testing automated tests fix fixes something broken P1 needed for current cycle labels May 27, 2025
@T4rk1n T4rk1n merged commit e04f4f9 into dev May 28, 2025
10 checks passed
@T4rk1n T4rk1n deleted the html-exp-attr branch May 28, 2025 19:23
@gvwilson
Copy link
Contributor

👍 well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixes something broken P1 needed for current cycle testing automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants