Skip to content

Fix _ID_CONTENT check for async version #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
T4rk1n merged 2 commits into from
Jul 4, 2025
Merged

Fix _ID_CONTENT check for async version #3361

T4rk1n merged 2 commits into from
Jul 4, 2025

Conversation

@Erraen
Copy link
Contributor

@Erraen Erraen commented Jul 1, 2025 •
edited by gvwilson
Loading

Fix #3360

@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken community community contribution labels Jul 2, 2025
@gvwilson
Copy link
Contributor

gvwilson commented Jul 2, 2025

thnaks @Erraen - @T4rk1n please check the change in logic from indenting the test one level further.

T4rk1n
T4rk1n approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good thank you.

@T4rk1n T4rk1n merged commit d9475e9 into plotly:dev Jul 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees

@T4rk1n T4rk1n

Labels

community community contribution fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] suppress_callback_exceptions checks for async version

3 participants

@Erraen @gvwilson @T4rk1n