Skip to content

Forward FastAPI reload scope options - #3987

Open
dajiaohuang wants to merge 2 commits into
plotly:devfrom
dajiaohuang:fix/3962-forward-fastapi-reload-options
Open

dajiaohuang wants to merge 2 commits into
plotly:devfrom
dajiaohuang:fix/3962-forward-fastapi-reload-options

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

Fixes #3962.

Forward the reload scope options passed to the FastAPI backend to the spawned Uvicorn process. This makes reload_dirs, reload_excludes, and reload_includes effective while preserving existing defaults.

Tests

  • pytest -q tests/backend_tests/test_preconfig_backends.py::test_fastapi_run_forwards_reload_scope
  • python -m py_compile dash/backends/_fastapi.py tests/backend_tests/test_preconfig_backends.py

Checklist

  • Tests pass
  • Tests were added for the change

@sonarqubecloud

Copy link
Copy Markdown

@dajiaohuang

Copy link
Copy Markdown
Author

Triage update for the two failing checks on head 374bc45: Run performance benchmarks completed its benchmark work but failed only when the workflow token attempted to create/update the benchmark summary comment (403 Resource not accessible by integration); WebSocket Tests (Python 3.9) ran 70 tests successfully and had one Selenium/Chrome failure with javascript error: u.concat is not a function on Chrome 152. The remaining checks, including SonarCloud, pass. No source change was made because both failures are workflow/runner-environment symptoms; maintainer rerun or workflow adjustment is needed.

@T4rk1n T4rk1n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need a changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Dash.run(debug=True, backend="fastapi") reload subprocess silently ignores reload_dirs/reload_excludes kwargs

2 participants