You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Forward the reload scope options passed to the FastAPI backend to the spawned Uvicorn process. This makes reload_dirs, reload_excludes, and reload_includes effective while preserving existing defaults.
Triage update for the two failing checks on head 374bc45: Run performance benchmarks completed its benchmark work but failed only when the workflow token attempted to create/update the benchmark summary comment (403 Resource not accessible by integration); WebSocket Tests (Python 3.9) ran 70 tests successfully and had one Selenium/Chrome failure with javascript error: u.concat is not a function on Chrome 152. The remaining checks, including SonarCloud, pass. No source change was made because both failures are workflow/runner-environment symptoms; maintainer rerun or workflow adjustment is needed.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need a changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3962.
Forward the reload scope options passed to the FastAPI backend to the spawned Uvicorn process. This makes
reload_dirs,reload_excludes, andreload_includeseffective while preserving existing defaults.Tests
pytest -q tests/backend_tests/test_preconfig_backends.py::test_fastapi_run_forwards_reload_scopepython -m py_compile dash/backends/_fastapi.py tests/backend_tests/test_preconfig_backends.pyChecklist