Skip to content

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Aug 13, 2025

Fixes #5253

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@gvwilson gvwilson self-requested a review August 13, 2025 18:47
@gvwilson gvwilson self-assigned this Aug 13, 2025
@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken testing automated tests labels Aug 13, 2025
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this, but it's worth mentioning that the mplexporter tests aren't currently running in the CI (which is how this was missed in the first place).

There are also two failing mplexporter tests currently:

FAILED plotly/matplotlylib/mplexporter/tests/test_basic.py::test_legend_dots - AssertionError: assert '3' == '2'
FAILED plotly/matplotlylib/mplexporter/tests/test_utils.py::test_linestyle - AssertionError: 

I've opened #5360 to track.

@emilykl emilykl merged commit fbbc9d6 into plotly:main Oct 1, 2025
8 checks passed
@mgorny mgorny deleted the plt-import branch October 2, 2025 03:20
@mgorny
Copy link
Contributor Author

mgorny commented Oct 2, 2025

Thank you!

@emilykl
Copy link
Contributor

emilykl commented Oct 2, 2025

Thank you for the fix @mgorny !! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution fix fixes something broken P1 needed for current cycle testing automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken imports in matplotlib tests in 6.2.0
3 participants