Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed main workflow failing for open-vsx due to pnpm dependency #179

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Fixed main workflow failing for open-vsx due to pnpm dependency #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af254fd
test
pmahend1 Feb 21, 2025
140f5de
changes
pmahend1 Feb 21, 2025
ec3023a
changes
pmahend1 Feb 21, 2025
c7b4c7e
changes
pmahend1 Feb 21, 2025
f3dfd91
changes
pmahend1 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 9
version: 10

- name: Install vsce and open vsx
run: |
Expand All @@ -36,11 +36,13 @@ jobs:
run: |
vsce publish --no-dependencies -p $env:VSCE_PAT
$VsixName = Get-ChildItem -Filter *.vsix | Select-Object -First 1 -ExpandProperty Name
"VSIX_FILENAME=$VsixName" >> $env:GITHUB_OUTPUT
"VSIX_FILENAME=$VsixName" >> $env:GITHUB_OUTPUT
env:
VSCE_PAT: ${{ secrets.VSCE_PRETTYXML }}

- name: Open VSX Publish
run: npx ovsx publish ${{ steps.vsce.outputs.VSIX_FILENAME }} -p $env:OPEN_VSX_PAT
run: |
Write-Host "Running npx ovsx publish --packagePath ${{ steps.vsce.outputs.VSIX_FILENAME }} -p $env:OPEN_VSX_PAT"
npx ovsx publish --packagePath ${{ steps.vsce.outputs.VSIX_FILENAME }} -p $env:OPEN_VSX_PAT
env:
OPEN_VSX_PAT: ${{ secrets.OPENVSX }}
2 changes: 1 addition & 1 deletion .github/workflows/pullrequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
run: |
$localVersion = [System.Version]('${{ steps.getpackageversion.outputs.VERSION }}')
$storeVersion = [System.Version]('${{ steps.getPublishedVersion.outputs.PUB_VERSION }}')

if ($localVersion -gt $storeVersion) {
Write-Host "Version in package.json is higher than latest published version"
Write-Host "Pass"
Expand Down
Loading