fix: version command issues

[nicholass003]

Introduction

This pull request is to handle users using the version command for detailed things, such as checking plugin information.

Relevant issues

Fixes #6322

Changes

API changes

Added DefaultPermissionNames::COMMAND_VERSION_DETAIL -> Allows the user to view the detailed version of the server.

Behavioural changes

Backwards compatibility

Follow-up

Tests

I tested this PR by doing the following (tick all that apply):

• Writing PHPUnit tests (commit these in the tests/phpunit folder)
• Playtesting using a Minecraft client (provide screenshots or a video)
• Writing a test plugin (provide the code and sample output)
• Other (provide details)

[ShockedPlot7560]

Need translation follow up

[nicholass003]

Need translation follow up

just added english for now, pmmp/Language#182

[dktapps]

I think "detailed version" and the general "detail" wording is too vague. Be more specific - this is for restricting access to plugin versions.

[nicholass003]

I think "detailed version" and the general "detail" wording is too vague. Be more specific - this is for restricting access to plugin versions.

Is there some suitable name for this?
i have several names :

• pocketmine.permission.command.version.plugins - Allows the user to view information about all server plugins.
• pocketmine.permission.command.version.info - Allows the user to view detailed information about all plugins used by the server.
• pocketmine.permission.command.version.pluginInfo - Allows the user to access information for all plugins on the server.

[dktapps]

First one seems the most obvious to me. Don't overthink it.

[dktapps]

that being said, those names look AI generated ...

[nicholass003]

that being said, those names look AI generated ...

for the desc yes 😁

[dktapps]

This will cause problems for people who set pocketmine.command.version expecting it to set this permission as well.

It's probably better to have:

• pocketmine.command.version.server
• pocketmine.command.version.plugins

and then have pocketmine.command.version as a deprecated backwards-compatible group permission for the remainder of PM5. See how this was done for /effect in PM4:

PocketMine-MP/src/permission/DefaultPermissions.php

Lines 71 to 73 in ba89ae5

	$effectRoot = self::registerDeprecatedPermission(Names::COMMAND_EFFECT);
	self::registerPermission(new Permission(Names::COMMAND_EFFECT_OTHER, "Allows the user to modify effects of other players"), [$operatorRoot, $effectRoot]);
	self::registerPermission(new Permission(Names::COMMAND_EFFECT_SELF, "Allows the user to modify their own effects"), [$operatorRoot, $effectRoot]);

This will permit people to still explicitly set pocketmine.command.version to get the same functionality as it would previously, but since it won't be given to any groups, default functionality will be controlled by these new permissions.

(Side note for maintainers: If #6324 were implemented, explicitly registering deprecated group roots wouldn't be necessary anymore.)