feat(typescript): add generics to src/random functions to properly infer TypedArray - #39
Open
mgcrea wants to merge 2 commits into
Open
feat(typescript): add generics to src/random functions to properly infer TypedArray#39mgcrea wants to merge 2 commits into
mgcrea wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: aa4a1ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aa4a1ba:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for the great lib,
Encountered a few TypeScript issues while using the library with
@react-three/dreiwhere props expects aFloat32Array.For instance the following code does not work currently (fails with
Argument of type '() => TypedArray' is not assignable to parameter of type 'Float32Array | (() => Float32Array)'.), however the return type should easily be inferred with generics, hence this PR.