Skip to content

fix(typescript): make Position fields nullable to match core #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 3 commits into from
Jul 2, 2026
+4 −4
Merged

fix(typescript): make Position fields nullable to match core #1418

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0578377
fix(typescript): make Position fields nullable to match core
AbhilashG12 Jun 30, 2026
d03ac6b
fix(typescript): remove inline comments from Position interface
AbhilashG12 Jul 1, 2026
02e36d7
fix: remove trailing whitespace in position model
realfishsam Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdks/typescript/pmxt/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,19 +349,19 @@ export interface Position {
outcomeId: string;

/** Outcome label (populated in venue-direct mode; may be undefined in hosted mode when the server hasn't enriched). */
outcomeLabel?: string;
outcomeLabel?: string | null;

/** Position size (positive for long, negative for short) */
size: number;

/** Average entry price (populated in venue-direct mode; may be undefined in hosted mode when the server hasn't enriched). */
entryPrice?: number;
entryPrice?: number | null;

/** Current market price (populated in venue-direct mode; may be undefined in hosted mode when the server hasn't enriched). */
currentPrice?: number;
currentPrice?: number | null;

/** Unrealized profit/loss (populated in venue-direct mode; may be undefined in hosted mode when the server hasn't enriched). */
unrealizedPnL?: number;
unrealizedPnL?: number | null;

/** Realized profit/loss */
realizedPnL?: number;
Expand Down
Loading