Skip to content

feat(router): add fetchOrderBook cross-venue orderbook merge to SDKs#1670

Closed
AbhilashG12 wants to merge 1 commit into
pmxt-dev:mainfrom
AbhilashG12:feat/router-fetch-orderbook
Closed

feat(router): add fetchOrderBook cross-venue orderbook merge to SDKs#1670
AbhilashG12 wants to merge 1 commit into
pmxt-dev:mainfrom
AbhilashG12:feat/router-fetch-orderbook

Conversation

@AbhilashG12

Copy link
Copy Markdown
Contributor
  • Add fetchOrderBook to TypeScript Router class
  • Add fetch_order_book to Python Router class
  • Update OpenAPI spec and docs
  • Add unit tests for both SDKs

Fixes #1450

- Add fetchOrderBook to TypeScript Router class
- Add fetch_order_book to Python Router class
- Update OpenAPI spec and docs
- Add unit tests for both SDKs

Fixes pmxt-dev#1450
realfishsam added a commit that referenced this pull request Jul 18, 2026
…1129, #1670)

Implements the intended net changes of two broken PRs onto current main:

- #1129: Router.sql(query) POSTs { query } to ${baseUrl}/v0/sql with the
  SDK's normal auth headers and returns a typed result. Adds SqlResult /
  SqlMeta / SqlColumn types to both SDKs, exported from each package root.
- #1670: Router.fetchOrderBook(outcomeId) — a cross-venue order book that
  routes through the /api/router/fetchOrderBook surface and returns a single
  merged book. In Python it is a proper Router method (4-space indent).

Adds focused unit tests (HTTP layer mocked) plus an AST check that Router
still exposes all pre-existing methods. #1419 (any->types) skipped: the
remaining any usages are raw wire JSON with no safe importable type.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
realfishsam added a commit that referenced this pull request Jul 18, 2026
Second wave of reworked community PRs: Router.sql (#1129),
cross-venue Router.fetchOrderBook (#1670), WebSocket config (#1126),
baozi error codes (#1118), limitless pagination (#1119), nullable
model fields (#1578). Excludes #1614 (security) and #1419 (superseded).
Triggers auto-tag v2.53.0f and package publish.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@realfishsam

Copy link
Copy Markdown
Contributor

Landed on main in commit d8ca8fb and released in v2.53.0. The change was reapplied on top of current main (dropping the stale reverts / encoding issues / compile errors the branch carried) and re-verified: Core 816, Python SDK 267, TypeScript SDK 93 tests pass. Thank you for the contribution! Closing as landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Router.fetchOrderBook (cross-venue orderbook merge) missing from both SDK Router classes

2 participants