fix(python): wrap malformed feed API errors#1725
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: air <air@MacBook-Air-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep Python FeedClient error handling aligned with the TypeScript SDK when a proxy or upstream returns a non-JSON error body. Malformed JSON and invalid UTF-8 now fall back to the HTTP reason while still raising the typed
PmxtError.Fixes #1700.
Testing
PmxtErrorwith the HTTP status/reason and preserves theHTTPErrorcause.venv/bin/pytest tests/test_feed_client.py -q- 2 passed.venv/bin/pytest tests -q- 268 passed, 66 deselected.venv/bin/black --check pmxt/feed_client.py tests/test_feed_client.pytwine check dist/*passedgit diff --checkProject-wide Mypy is not claimed: the current configuration targets unsupported Python 3.8 under the installed Mypy and reports 118 existing SDK errors, including one pre-existing
no-any-returninfeed_client.py:102.AI Assistance Disclosure
OpenAI Codex assisted with issue investigation, implementation, regression-test creation, and validation. I reviewed the final diff and test results.