Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download releases from github #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Download releases from github #20

wants to merge 1 commit into from

Conversation

wuzzeb
Copy link

@wuzzeb wuzzeb commented Sep 8, 2021

To support version ranges and tool caching, I updated the action to download from github releases. But then node 16.9 just came out with corepack built in. I switched my own projects to just using actions/setup-node and running corepack enable and got rid of this action completely, but I thought I would still send a pull request.

Features:

Removed:

I took out the call to pnpm cache prune. I initially tried to keep it in but the problem is the pnpm cache prune is run at the wrong time with the caching in setup-node. I plan on instead submitting a patch to actions/setup-node to run pnpm cache prune as part of the caching in actions/setup-node, but for now I just run pnpm cache prune as the final step in the job flow.

Copy link
Collaborator

@KSXGitHub KSXGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use existing code style?

@zkochan
Copy link
Member

zkochan commented Dec 15, 2021

Seems like a lot of changes were done. Will we finish this?

@KSXGitHub
Copy link
Collaborator

@zkochan The diff is massive but I bet the actual change is minimal. OP just use a different code formatter from the one I use. Also, I am very reluctant to merge this.

@wuzzeb
Copy link
Author

wuzzeb commented Dec 16, 2021

For the past 3 months I have been using corepack and not using this action, and corepack has been working great. corepack lets you use a specific version specified in the package.json, handles all the downloading and install.

      - uses: actions/setup-node@v2
        with:
          node-version: "16.9"
      - run: corepack enable

I can close this pull request, unless there is someone else that wants to continue with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: built-in pnpm modules cache manager
3 participants