fix: do not move packages that are not shared to catalog

[mcous]

Hello, thanks for this codemod! I tried it out in a monorepo, and noticed this aspect of the docs was not true:

If there are more than 2 packages with same dependency - it will move dependency to catalog.

Instead, the codemod moved all dependencies to the catalog, which wasn't what I wanted. In case the difference was unintentional, this PR updates the codemod to behave according to the docs. In addition to tracking the version count, it also tracks the dependent count, so we only select dependencies that have a single version used across multiple dependencies

[deanc]

Same observation here. This codemod did the exact opposite of what it said it would do. It "catalogged" all the packages that were used once, and none of those used 2+ times.

[zkochan]

I think moving everything to catalogs is also a valuable feature. Do codemods support flags or options to support both?

[mcous]

I think moving everything to catalogs is also a valuable feature. Do codemods support flags or options to support both?

@zkochan I've not worked with codemods before this PR, but a quick glance at their docs seem to indicate that yes, arguments are supported. Would you like me to update this PR with argument(s) to support both the current behavior of moving all packages and the docs-stated behavior of moving duplicated packages? If so, do you have any preferences on the argument names and/or defaults?

Some sort of "threshold" argument would be easy to tack on to this PR without much fuss - i.e. "if [N] or more packages have this dependency, move it to the catalog"

[zkochan]

I guess it depends on what will be the default. We could have something like --duplicates-only or --all-deps.

[mcous]

"Only duplicates" was the behavior I was seeking out as a user to try catalogs for the first time. I think it's a sensible default while the catalogs feature is still relatively new and isn't fully integrated into stuff like pnpm update.

That being said, as long as both are possible I don't much mind either way. I defer to your judgement if you feel "all dependencies" is a better default

[zkochan]

I wasn't the one who created the codemod. If the README says that only duplicates are moved to catalogs, then I am OK with that being the default.

[mcous]

I investigated this last night, and I couldn't figure out how to get arguments working. I'm not familiar with codemods, and their docs are kind of non-existent (in favor of upsells and pushing to AI tooling)

Accordingly, I do not intend to make any more updates to this PR. If you'd like to merge it as is to make the behavior match the documentation, please do! Otherwise feel free to close it (and maybe update the docs)

[sebastienbarre]

Thanks for the work.
Any update on this? I too noticed that all dependencies were moved to the catalog, instead of the shared ones.

UPDATE: meanwhile, here is what you can do

• Clone mcous/codemod (or fork, then clone your own).
• Checkout the fix-non-shared branch, where the fix is, or commit 5acf6b3 directly
• Run pnpm install
• From your repo, run pnpx codemod -s [path to the mcous/codemod repo]/catalog/