Skip to content

Add option to also parse player clippings#376

Open
JanEricNitschke wants to merge 1 commit into
pnxenopoulos:mainfrom
JanEricNitschke:allow-parsing-of-clippings
Open

Add option to also parse player clippings#376
JanEricNitschke wants to merge 1 commit into
pnxenopoulos:mainfrom
JanEricNitschke:allow-parsing-of-clippings

Conversation

@JanEricNitschke
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • scripts/generate-tris.ps1: Language not supported
Comments suppressed due to low confidence (2)

awpy/cli.py:121

  • [nitpick] Consider renaming the CLI function parameter 'include_player_clippings' to 'including_player_clippings' to match the naming used in VphysParser for consistency.
def generate_tri(vphys_file: Path, *, outpath: Path | None = None, include_player_clippings: bool) -> None:

awpy/visibility.py:331

  • Ensure that unit tests cover both scenarios when 'including_player_clippings' is true and false to validate the new parsing behavior.
if including_player_clippings:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants