image/blobinfocache: do not assume time.Now() is unique in tests - #1038
Open
vtushar06 wants to merge 1 commit into
Open
image/blobinfocache: do not assume time.Now() is unique in tests#1038vtushar06 wants to merge 1 commit into
vtushar06 wants to merge 1 commit into
Conversation
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1035.
I could not get it to fail on my machine - it reports a 250ns tick and only 0.01% duplicates from
time.Now()- so I measured the mechanism instead. ARecordKnownLocationon the memory cache takes about 172ns here, which is less than one tick on a machine with microsecond resolution, so two locations recorded one after the other cannot get distinct timestamps there.To see which tests actually depend on it I truncated the recorded time to a millisecond to stand in for a very coarse clock. That fails six subtests, not one: RecordKnownLocations, CandidateLocations and CandidateLocations2, in both the no Open and with Open variants. So the assumption is in more places than the one you hit.
The fix is a small wrapper that records a location and then waits for
time.Now()to change, used at the four ordering sensitive call sites. Waiting for the clock rather than sleeping a fixed amount means it costs one tick whatever the platform resolution is. With the same truncation applied to both the cache and the wrapper the six subtests pass again, and normally the whole thing is under the noise - memory, boltdb and sqlite all measure the same as before within a tenth of a second.I left the single record in the unknown-location test alone since nothing depends on its order.