image: fix full-width punctuation in registries.conf documentation - #1050
Open
Arunendra21 wants to merge 1 commit into
Open
Conversation
A few spots in the registries.conf man page and the matching Go doc comment used full-width CJK punctuation instead of plain ASCII. This fixes the full-width colon after `location` and `insecure` in the mirror fields section, and the full-width comma after "digest-only" in both the man page and the PullFromMirror comment in image/pkg/sysregistriesv2/system_registries_v2.go. These render oddly and are just typos, so this swaps them for a regular ASCII colon and comma. Signed-off-by: Arunendra21 <156455722+Arunendra21@users.noreply.github.com> Co-authored-by: eeshsaxena <eeshsaxena@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same fix as containers/image#2975, reopened here after the migration bot noted that containers/image has moved into this repository.
A few spots in the registries.conf man page and the matching Go doc comment use full-width CJK punctuation instead of plain ASCII. This replaces them with regular ASCII punctuation.
In
image/docs/containers-registries.conf.5.md, the mirror fields list used a full-width colon (U+FF1A) afterlocationandinsecure, and a full-width comma (U+FF0C) after "digest-only". The same full-width comma also appears in thePullFromMirrordoc comment inimage/pkg/sysregistriesv2/system_registries_v2.go, which is where the man page text comes from.These are just typos. They look off in the rendered man page and are inconsistent with the rest of the file, which already uses ASCII colons and commas (for example the
pull-from-mirrorline right below already uses a normal colon). The change is documentation and comments only, so there is no behavior change.