overlay: treat EACCES/EPERM metacopy probe failure as unsupported - #1068
Merged
giuseppe merged 1 commit intoAug 12, 2026
Merged
Conversation
Luap99
reviewed
Aug 12, 2026
giuseppe
force-pushed
the
overlay-check-rootless
branch
from
August 12, 2026 10:05
b1c0ebc to
f2d1be5
Compare
doesMetacopy() already treats EINVAL from the probe mount as "metacopy not supported" and lets the driver initialise with metacopy off. In a restricted unprivileged user namespace the plain overlay mount can succeed while the metacopy probe mount is refused with EACCES (or EPERM), which was propagated out of Init() as a fatal error and left the driver unusable, even though it would work perfectly with metacopy disabled. Closes: podman-container-tools#1053 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
overlay-check-rootless
branch
from
August 12, 2026 10:10
f2d1be5 to
c5a9f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doesMetacopy() already treats EINVAL from the probe mount as "metacopy not supported" and lets the driver initialise with metacopy off. In a restricted unprivileged user namespace the plain overlay mount can succeed while the metacopy probe mount is refused with EACCES (or EPERM), which was propagated out of Init() as a fatal error and left the driver unusable, even though it would work perfectly with metacopy disabled.
Closes: #1053