image: Skip creating lock file if short-name-aliases.conf is missing - #969
Open
Lekensteyn wants to merge 1 commit into
Open
image: Skip creating lock file if short-name-aliases.conf is missing#969Lekensteyn wants to merge 1 commit into
Lekensteyn wants to merge 1 commit into
Conversation
mtrmac
reviewed
Jul 8, 2026
mtrmac
left a comment
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
I’m pretty unconvinced this makes much of a difference ultimately — Podman must have writable storage for mount counting and locks, after all — but if it can be done cleanly, why not.
Lekensteyn
force-pushed
the
skip-short-name-lock-ro
branch
from
July 8, 2026 22:30
bb9be0c to
6c5fc25
Compare
Contributor
Author
Thanks for the review! I should've addressed all comments. Yes, writeable storage is required, here I just try to remove unnecessary writes and new directories that would have been empty otherwise. |
mtrmac
requested changes
Jul 9, 2026
The lock file `~/.cache/containers/short-name-aliases.conf.lock` used to be created in all cases, even for read-only attempts for a non-existing `~/.cache/containers/short-name-aliases.conf` file. Do not create this file unless necessary, this keeps the home directory a bit cleaner. Link: podman-container-tools/podman#27921 Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Lekensteyn
force-pushed
the
skip-short-name-lock-ro
branch
from
July 9, 2026 20:54
6c5fc25 to
314548e
Compare
Contributor
Author
|
All comments have been addressed, is there anything else you'd like me to address @mtrmac? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lock file
~/.cache/containers/short-name-aliases.conf.lockused to be created in all cases, even for read-only attempts for a non-existing~/.cache/containers/short-name-aliases.conffile. Do not create this file unless necessary, this keeps the home directory a bit cleaner.Link: podman-container-tools/podman#27921