Frontend: scaffold, bottom nav, inventory list with mock data#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend scaffold: PWA skeleton, inventory list, CI
Decisions worth noting
@import "tailwindcss"and@tailwindcss/vite; no separate config file neededvitest/configinstead of/// <reference types="vitest" />— the triple-slash directive was not picked up by the TypeScript compiler; importingdefineConfigfromvitest/configis the reliable alternativesrc/mocks/— shared between UI (renders while there are no API calls yet) and tests; outside a test directory so nothing needs to move when real API calls are wired insrc/features/inventory/for page and components — page component alongside its sub-components and tests; avoids a separatepages/layer for feature-scoped codeendprop on the/NavLink — without it the Inventory tab stays active on every route since all paths start with/format:checkruns before lint and tests in CI — formatting is the cheapest check; failing fast on it avoids paying for test and build time on unformatted codefetch-pr-comments.shnow fetches review summaries — the GitHub reviews endpoint (/pulls/{pr}/reviews) is separate from inline and issue comments; the script was missing it, causing review bodies from the Claude CI action to not appear locallyWhat's next
Run
npm run formatto reformat existing source files to match Prettier, commit that separately as a style-only change, then deploy to Vercel.