Skip to content

Frontend: scaffold, bottom nav, inventory list with mock data#16

Merged
podmar merged 10 commits into
mainfrom
feat/scaffold-frontend
Jul 4, 2026
Merged

Frontend: scaffold, bottom nav, inventory list with mock data#16
podmar merged 10 commits into
mainfrom
feat/scaffold-frontend

Conversation

@podmar

@podmar podmar commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Frontend scaffold: PWA skeleton, inventory list, CI

Decisions worth noting

  • Tailwind v4 — uses @import "tailwindcss" and @tailwindcss/vite; no separate config file needed
  • vitest/config instead of /// <reference types="vitest" /> — the triple-slash directive was not picked up by the TypeScript compiler; importing defineConfig from vitest/config is the reliable alternative
  • Mock data in src/mocks/ — shared between UI (renders while there are no API calls yet) and tests; outside a test directory so nothing needs to move when real API calls are wired in
  • src/features/inventory/ for page and components — page component alongside its sub-components and tests; avoids a separate pages/ layer for feature-scoped code
  • end prop on the / NavLink — without it the Inventory tab stays active on every route since all paths start with /
  • PWA manifest has no icons — icon references removed rather than left pointing at files that don't exist; icons will be added once a logo is decided
  • Frontend CI runs on push to main and on PRs — push-to-main covers direct pushes that bypass the PR flow; PR trigger covers every commit added to a branch under review
  • Prettier added alongside oxlint — oxlint lints but does not format; without Prettier the editor formatter and the codebase had no shared style contract, causing quote style drift on save
  • format:check runs before lint and tests in CI — formatting is the cheapest check; failing fast on it avoids paying for test and build time on unformatted code
  • fetch-pr-comments.sh now fetches review summaries — the GitHub reviews endpoint (/pulls/{pr}/reviews) is separate from inline and issue comments; the script was missing it, causing review bodies from the Claude CI action to not appear locally

What's next

Run npm run format to reformat existing source files to match Prettier, commit that separately as a style-only change, then deploy to Vercel.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

  • PWA manifest references icon files that don't exist yet

Cost: $0.31

@podmar
podmar merged commit a04c418 into main Jul 4, 2026
1 check passed
@podmar
podmar deleted the feat/scaffold-frontend branch July 4, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant