fix: catch unwind for serve_connection #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
force-pushed
the
catch-unwind-for-server-conn
branch
2 times, most recently
from
9b9566f
to
7fe8041
Compare
|
Tested locally. Work well. |
Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
catch-unwind-for-server-conn
branch
from
7fe8041
to
66c02aa
Compare
|
Can this condition add a test case? |
|
I don't know your test suites and conventions, so if you can add it or point the position of the cases, it would be helpful. |
|
And you can trigger the CI so that we know if it introduces some regressions. |
|
Looks fine. Thanks~ |
|
Thank you! Perhaps you can trigger a release so that I'd upgrade to the new version and run the regression tests in my project also :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #843.