Fixes MeshColliders for .glb and .bam imported meshes#656
Draft
Noahnoah55 wants to merge 4 commits into
Draft
Conversation
Author
|
Uuuuuh this might be more complicated than I thought. Merged recent commits and updated my game project to see the collision meshes flipped an entirely different way. |
|
So it seems from the last message of the author of this PR, that the fixes that he was trying to make, to fix the mesh collider's rotation issue, either didn't worked as intended or was too hard to fix, so he gave up. @pokepetter Best to close this PR as well, since no future work in going to happen on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing .glb and .bam models and creating a MeshCollider from them, the resulting collider is rotated 90 degrees due to the difference between Ursina and Panda3D's coordinate systems.
I added an extra step in the generation of a MeshCollider from a NodePath to correct for this difference.