feat: Allow join_nulls in asof join
#21172
Open
+274
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
NicolasMuellerQC
force-pushed
the
asof_nulls
branch
from
0f67e22 to
98e0d1a
Compare
Comment on lines
+296
to
+303
| let left_by_bin = left_by_s.strict_cast(&DataType::Binary)?; | ||
| let right_by_bin = right_by_s.strict_cast(&DataType::Binary)?; | ||
|
|
||
| let left_by = left_by_bin.binary().unwrap(); | ||
| let right_by = right_by_bin.binary().unwrap(); | ||
| asof_join_by_binary::<BinaryType, T, A, F>( | ||
| left_by, right_by, left_asof, right_asof, filter, allow_eq, join_nulls, | ||
| ) |
There was a problem hiding this comment.
Is there a better way to use asof_join_by_binary with numerical types?
Or even better, is it easily possible to adjust asof_join_by_numeric to work with nulls in the by column?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21172 +/- ##
==========================================
+ Coverage 79.88% 79.89% +0.01%
==========================================
Files 1593 1593
Lines 227640 227671 +31
Branches 2600 2600
==========================================
+ Hits 181856 181906 +50
+ Misses 45187 45168 -19
Partials 597 597 ☔ View full report in Codecov by Sentry. |
NicolasMuellerQC
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
NicolasMuellerQC
force-pushed
the
asof_nulls
branch
from
b506297 to
8fd6f98
Compare
NicolasMuellerQC
force-pushed
the
asof_nulls
branch
from
8fd6f98 to
0a97578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17886: This PR introduces a
join_nullsoption to thebypart ofjoin_asof.