Repository navigation
Tags support - #3
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for syncing tags between TickTick tasks and Org Mode headings. Tags are now preserved during bidirectional synchronization.
- Extract and format tags when converting TickTick tasks to Org headings
- Extract and serialize tags when converting Org headings to TickTick task data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| (if (and tags (> (length tags) 0)) | ||
| (concat " :" (mapconcat #'identity tags ":") ":") | ||
| "")) |
There was a problem hiding this comment.
The mapconcat function expects a sequence (list, vector, or string), but tags from the TickTick API (parsed with json-array-type 'list at line 369) will be a list. While this is correct, the check (> (length tags) 0) could fail if tags is not a sequence type. Consider using (and tags (not (seq-empty-p tags))) for more robust type checking, or add an explicit listp check.
There was a problem hiding this comment.
Unnecessary, sinceAPI omits tags when there are no tags.
|
Thanks for your PR! Taking a look today. |
| (if (and tags (> (length tags) 0)) | ||
| (concat " :" (mapconcat #'identity tags ":") ":") | ||
| "")) |
There was a problem hiding this comment.
Unnecessary, sinceAPI omits tags when there are no tags.
No description provided.