Add acme-dns provider support#1033
Open
rbicker wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new built-in DNS provider implementation for acme-dns so Acmebot can perform delegated DNS-01 challenges via configured “synthetic zones”, reusing the existing suffix-based zone matching logic.
Changes:
- Introduces
AcmeDnsProviderwith configurable endpoint, propagation delay, and per-zone delegated subdomain + credentials. - Wires the new provider into DNS provider registration and top-level options (
AcmebotOptions). - Updates documentation site provider list/count and refreshes the generated ARM template output.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Acmebot.App/Providers/AcmeDnsProvider.cs | New DNS provider implementation that calls the acme-dns update API to set TXT challenge values. |
| src/Acmebot.App/Program.cs | Registers AcmeDnsProvider when Acmebot:AcmeDns configuration is present. |
| src/Acmebot.App/Options/AcmeDnsOptions.cs | Adds options model for acme-dns endpoint, propagation delay, and zone mappings/credentials. |
| src/Acmebot.App/Options/AcmebotOptions.cs | Exposes AcmeDns as a configurable DNS provider option. |
| docs/index.html | Updates DNS provider count/list and adjusts the “providers note” copy to mention acme-dns. |
| deploy/azuredeploy.json | Updates generated ARM template metadata and role assignment scope expression output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+22
| var duplicateZoneNames = options.Zones.GroupBy(x => x.Name, StringComparer.OrdinalIgnoreCase) | ||
| .Where(x => x.Count() > 1) | ||
| .Select(x => x.Key) | ||
| .ToArray(); | ||
|
|
Comment on lines
+56
to
+59
| foreach (var value in values.Distinct(StringComparer.Ordinal)) | ||
| { | ||
| await _acmeDnsClient.UpdateTxtRecordAsync(zoneOption, value, cancellationToken); | ||
| } |
| message.Headers.TryAddWithoutValidation("X-Api-User", zone.Username); | ||
| message.Headers.TryAddWithoutValidation("X-Api-Key", zone.Password); | ||
|
|
||
| var response = await _httpClient.SendAsync(message, cancellationToken); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add built-in support for the
acme-dns(https://github.com/acme-dns/acme-dns) DNS provider.This implementation uses configured synthetic zones so the existing suffix-based DNS provider matching logic can be reused. It is intended for the standard
acme-dnsworkflow where the user:acme-dns_acme-challengeCNAME in the primary DNS zoneConfiguration
Example app settings:
Acmebot__AcmeDns__EndpointAcmebot__AcmeDns__PropagationSecondsAcmebot__AcmeDns__Zones__0__NameAcmebot__AcmeDns__Zones__0__SubdomainAcmebot__AcmeDns__Zones__0__UsernameAcmebot__AcmeDns__Zones__0__PasswordNotes
acme-dnscleanup is intentionally a no-op because the upstream API supports record updates but not record deletion.acme-dnsregistration or primary DNS CNAME creation.Validation
dotnet restore ./Acmebot.slnxdotnet build -c Release ./Acmebot.slnxdotnet format --verify-no-changes --verbosity detailed --no-restore ./Acmebot.slnxbicep build ./deploy/azuredeploy.bicep