Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Layout: Update Tabler dependency, revamp layout #55

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

earboxer
Copy link
Contributor

@earboxer earboxer commented Feb 22, 2020

This is a replacement for #54

To test this, npm install && npm run gulp in this project, you may also need to run php artisan otter:install in your main project.

This PR simplifies the stylesheets: No more SCSS!!! Tabler now supports dark themes, so we don't need to add any of our own code.

This changes the layout to use CSS Grid (rather than the mix of bootstrap and tabler class names).

This changes the navigation menu to use blade to create it in blade instead of in vue. (it also only appears once in the DOM instead of twice). It is not hidden behind a hamburger menu anymore for small screens).
You should test this to make sure it works: I don't have any nested menus, so it may not work with those.

With the node update, some things changed, some of which are commented out:

  • updated trumbowyg (You should test this out, I have not tested it!)
  • sparkline and circle-progress are not distributed the same way in the new version of tabler: I'm not sure if this means we have a problem, we're including tabler.js (instead of their old core file, so maybe it is included?).
  • feather webfont is no longer distributed by tabler... do we need this? (maybe we should uncommit it from our /public folder when we compile the assets)

@earboxer
Copy link
Contributor Author

I pushed it without the compiled files. Line-wise, the biggest change is package-lock.json ... ugh NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant